소스 검색

Fix IDE warnings in import venues script

Alan Lam 5 년 전
부모
커밋
191fb9bac0
1개의 변경된 파일과 17개의 추가작업 그리고 6개의 파일을 삭제
  1. 17 6
      tasks/import_venues.php

+ 17 - 6
tasks/import_venues.php

@@ -27,9 +27,9 @@ $customer = Customer::get($customer_id);
 if(!$customer) die("Customer not found.");
 
 $confirm = trim(readline($customer->name . ": Confirm Y/N: "));
-if($confirm != "Y") die("Aborted");
+if($confirm !== "Y") die("Aborted");
 
-$handle = fopen($path, "r");
+$handle = fopen($path, "rb");
 
 date_default_timezone_set("UTC");
 
@@ -39,13 +39,16 @@ for($i = 0; $data = fgetcsv($handle); $i++) {
 
 	$data = array_map("trim", $data);
 
-	if($i == 0) {
+	if($i === 0) {
 		// Header
 		foreach($data as $index => $field_name) {
 			switch($field_name) {
 
+				case "Internal ID": $internal_id_column = $index; break;
+
 				case "Name": $name_column = $index; break;
 				case "Legal Entity Name": $legal_entity_name_column = $index; break;
+
 				case "Address": $address_column = $index; break;
 				case "Address 1": $address_1_column = $index; break;
 				case "Address 2": $address_2_column = $index; break;
@@ -56,21 +59,28 @@ for($i = 0; $data = fgetcsv($handle); $i++) {
 				case "Postal Code": $postal_code_column = $index; break;
 				case "State": $state_column = $index; break;
 				case "Country": $country_column = $index; break;
+
 				case "Email": $email_column = $index; break;
 				case "Phone": $phone_column = $index; break;
+
 				case "Opening Hours": $opening_hours_column = $index; break;
 				case "Closing Hours": $closing_hours_column = $index; break;
+
 				case "Shop Left": $shop_left_column = $index; break;
 				case "Shop Right": $shop_right_column = $index; break;
+
 				case "Brand": $brand_column = $index; break;
 				case "Region": $region_column = $index; break;
 				case "Region Name": $region_name_column = $index; break;
-				case "Internal ID": $internal_id_column = $index; break;
+
 				case "Area Manager": $area_manager_column = $index; break;
 				case "Area Manager Name": $area_manager_name_column = $index; break;
 				case "Area Manager Email": $area_manager_email_column = $index; break;
+
 				case "Operations Manager Name": $operations_manager_name_column = $index; break;
+
 				case "Closed": $closed_column = $index; break;
+
 				case "Latitude": $latitude_column = $index; break;
 				case "Longitude": $longitude_column = $index; break;
 
@@ -119,8 +129,8 @@ for($i = 0; $data = fgetcsv($handle); $i++) {
 
 		$count = count($parts);
 
-		if($count === 2) list($address_2, $city) = $parts;
-		else if($count === 1) list($city) = $parts;
+		if($count === 2) [$address_2, $city] = $parts;
+		else if($count === 1) [$city] = $parts;
 
 	}
 
@@ -187,6 +197,7 @@ for($i = 0; $data = fgetcsv($handle); $i++) {
 		for($attempt = 0; $attempt < 2; $attempt++) {
 
 			switch($attempt) {
+				default:
 				case 0: $query = $location->getDisplayAddress(); break;
 				case 1: $query = $postal_code; break;
 			}