Răsfoiți Sursa

Fix pass percentage

Alan Lam 7 ani în urmă
părinte
comite
065833939a

+ 8 - 2
controllers/test_results_test_list.php

@@ -29,8 +29,14 @@ $test_count = $project->getTestCount();
 $pass_count = $project->getPassCount();
 $fail_count = $project->getFailCount();
 
-$pass_percentage = number_format($pass_count / $test_count, 4) * 100;
-$fail_percentage = 100 - $pass_percentage;
+$pass_percentage = 0;
+$fail_percentage = 0;
+
+$pass_fail_count = $pass_count + $fail_count;
+if($pass_fail_count > 0) {
+    $pass_percentage = number_format($pass_count / $pass_fail_count, 4) * 100;
+    $fail_percentage = 100 - $pass_percentage;
+}
 
 $project_list_url = $customer->getTestResultsUrl();
 $test_list_url = $project->getTestResultsUrl();

+ 1 - 1
views/test_results_test_list.php

@@ -41,7 +41,7 @@
                     <div class="card-body">
                         Pass Rate
                         <div class="stat mb-3">
-                            <?=number_format($pass_count)?> Pass / <?=number_format($fail_count)?> Fail (<?=intval($pass_percentage)?>%)
+                            <?=number_format($pass_count)?> Pass / <?=number_format($fail_count)?> Fail (<?=intval($pass_percentage)?>% Pass)
                         </div>
                         <div class="progress">
                             <div class="progress-bar bg-success" role="progressbar" style="width: <?=$pass_percentage?>%"></div>